Remove dead Meta ecosystem build steps from the Alpine Dockerfile
Delete the commented-out Folly/Fizz/Wangle/mvfst/fbthrift/CacheLib RUN blocks instead of carrying them as dead code; keep a short explanatory comment in the Dockerfile and move the fuller rationale to INCLUDED_LIBRARIES.md, scoped explicitly to alpine3.24 since debian13 and rockylinux9 are glibc-based and build the full Meta stack. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGpSs9pKTbvPkmFvBaWhBp
This commit is contained in:
1 parent
1f23774796
commit
c6d2f963d2
2 files changed
+4
-67
No files matched your search
@@ -46,3 +46,5 @@
|
|||||||
| libxml2 | `2.15.3` |
|
| libxml2 | `2.15.3` |
|
||||||
|
|
||||||
The image includes position-independent static builds of these libraries. Protobuf and libxml2 enable zlib support, and LibDwarf enables compressed debug section support using zlib and Zstd. ZeroMQ enables CURVE security using static libsodium. CZMQ enables UUID support using static util-linux libuuid while disabling undeclared optional integrations. librdkafka includes SSL, zlib, Zstd, and bundled LZ4 support while disabling undeclared optional integrations. spdlog uses external fmt, glog uses gflags, and all Meta libraries share the same release tag.
|
The image includes position-independent static builds of these libraries. Protobuf and libxml2 enable zlib support, and LibDwarf enables compressed debug section support using zlib and Zstd. ZeroMQ enables CURVE security using static libsodium. CZMQ enables UUID support using static util-linux libuuid while disabling undeclared optional integrations. librdkafka includes SSL, zlib, Zstd, and bundled LZ4 support while disabling undeclared optional integrations. spdlog uses external fmt, glog uses gflags, and all Meta libraries share the same release tag.
|
||||||
|
|
||||||
|
**Alpine-only exception:** the `alpine3.24` image does not build Folly, Fizz, Wangle, mvfst, fbthrift, or CacheLib. These aren't on Meta's supported-OS list, and Folly's portability layer reaches for glibc-only macros/symbols with no musl branch (e.g. `off64_t`/`lseek64`/`pread64` in `folly/portability/Unistd.h`, `__ELF_NATIVE_CLASS` in `folly/debugging/symbolizer/Elf.cpp`), so patching each one as it surfaces risks introducing subtle bugs in code this project doesn't own. `debian13` and `rockylinux9` are glibc-based and build the full list above, Meta libraries included.
|
||||||
+2
-67
@@ -334,73 +334,8 @@ RUN curl --fail --location --output numactl.tar.gz \
|
|||||||
# folly/portability/Unistd.h, __ELF_NATIVE_CLASS in
|
# folly/portability/Unistd.h, __ELF_NATIVE_CLASS in
|
||||||
# folly/debugging/symbolizer/Elf.cpp). Patching around each one as it
|
# folly/debugging/symbolizer/Elf.cpp). Patching around each one as it
|
||||||
# surfaces is more likely to introduce subtle bugs than to reach a solid
|
# surfaces is more likely to introduce subtle bugs than to reach a solid
|
||||||
# build, so this stack is intentionally left unbuilt on Alpine.
|
# build, so this stack is not built here. See INCLUDED_LIBRARIES.md for
|
||||||
# RUN git clone --branch=v2026.08.03.00 --depth=1 https://github.com/facebook/folly.git src \
|
# details; debian13 and rockylinux9 are unaffected and still build it.
|
||||||
# && CXXFLAGS="-DGLOG_USE_GLOG_EXPORT" \
|
|
||||||
# cmake -G Ninja -S src -B build -DCMAKE_BUILD_TYPE=Release \
|
|
||||||
# -DBOOST_LINK_STATIC=ON \
|
|
||||||
# -DBUILD_BENCHMARKS=OFF \
|
|
||||||
# -DBUILD_SHARED_LIBS=OFF \
|
|
||||||
# -DBUILD_TESTS=OFF \
|
|
||||||
# -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
|
|
||||||
# -DPYTHON_EXTENSIONS=OFF \
|
|
||||||
# && cmake --build build --parallel "$(nproc)" --target install \
|
|
||||||
# && rm -rf build src
|
|
||||||
|
|
||||||
# RUN git clone --branch=v2026.08.03.00 --depth=1 https://github.com/facebookincubator/fizz.git src \
|
|
||||||
# && CXXFLAGS="-DGLOG_USE_GLOG_EXPORT" \
|
|
||||||
# cmake -G Ninja -S src/fizz -B build -DCMAKE_BUILD_TYPE=Release \
|
|
||||||
# -DBUILD_EXAMPLES=OFF \
|
|
||||||
# -DBUILD_SHARED_LIBS=OFF \
|
|
||||||
# -DBUILD_TESTS=OFF \
|
|
||||||
# -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
|
|
||||||
# -Dsodium_USE_STATIC_LIBS=ON \
|
|
||||||
# && cmake --build build --parallel "$(nproc)" --target install \
|
|
||||||
# && rm -rf build src
|
|
||||||
|
|
||||||
# RUN git clone --branch=v2026.08.03.00 --depth=1 https://github.com/facebook/wangle.git src \
|
|
||||||
# && CXXFLAGS="-DGLOG_USE_GLOG_EXPORT" \
|
|
||||||
# cmake -G Ninja -S src/wangle -B build -DCMAKE_BUILD_TYPE=Release \
|
|
||||||
# -DBUILD_EXAMPLES=OFF \
|
|
||||||
# -DBUILD_SHARED_LIBS=OFF \
|
|
||||||
# -DBUILD_TESTS=OFF \
|
|
||||||
# -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
|
|
||||||
# && cmake --build build --parallel "$(nproc)" --target install \
|
|
||||||
# && rm -rf build src
|
|
||||||
|
|
||||||
# RUN git clone --branch=v2026.08.03.00 --depth=1 https://github.com/facebook/mvfst.git src \
|
|
||||||
# && CXXFLAGS="-DGLOG_USE_GLOG_EXPORT" \
|
|
||||||
# cmake -G Ninja -S src -B build -DCMAKE_BUILD_TYPE=Release \
|
|
||||||
# -DBUILD_SAMPLES=OFF \
|
|
||||||
# -DBUILD_SHARED_LIBS=OFF \
|
|
||||||
# -DBUILD_TESTS=OFF \
|
|
||||||
# -DBUILD_TOOLS=OFF \
|
|
||||||
# -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
|
|
||||||
# && cmake --build build --parallel "$(nproc)" --target install \
|
|
||||||
# && rm -rf build src
|
|
||||||
|
|
||||||
# RUN git clone --branch=v2026.08.03.00 --depth=1 https://github.com/facebook/fbthrift.git src \
|
|
||||||
# && CXXFLAGS="-DGLOG_USE_GLOG_EXPORT" \
|
|
||||||
# cmake -G Ninja -S src -B build -DCMAKE_BUILD_TYPE=Release \
|
|
||||||
# -DBUILD_SHARED_LIBS=OFF \
|
|
||||||
# -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
|
|
||||||
# -DTHRIFT_BENCHMARKS=OFF \
|
|
||||||
# -Denable_tests=OFF \
|
|
||||||
# -Dthrift_python=OFF \
|
|
||||||
# -Dthriftpy=OFF \
|
|
||||||
# -Dthriftpy3=OFF \
|
|
||||||
# && cmake --build build --parallel "$(nproc)" --target install \
|
|
||||||
# && rm -rf build src
|
|
||||||
|
|
||||||
# RUN git clone --branch=v2026.08.03.00 --depth=1 https://github.com/facebook/CacheLib.git src \
|
|
||||||
# && CXXFLAGS="-DGLOG_USE_GLOG_EXPORT" \
|
|
||||||
# cmake -G Ninja -S src/cachelib -B build -DCMAKE_BUILD_TYPE=Release \
|
|
||||||
# -DBOOST_LINK_STATIC=ON \
|
|
||||||
# -DBUILD_SHARED_LIBS=OFF \
|
|
||||||
# -DBUILD_TESTS=OFF \
|
|
||||||
# -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
|
|
||||||
# && cmake --build build --parallel "$(nproc)" --target install \
|
|
||||||
# && rm -rf build src
|
|
||||||
|
|
||||||
RUN curl --fail --location --output util-linux.tar.xz \
|
RUN curl --fail --location --output util-linux.tar.xz \
|
||||||
https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.42/util-linux-2.42.2.tar.xz \
|
https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.42/util-linux-2.42.2.tar.xz \
|
||||||
|
|||||||
Reference in new issue
Block a user